<html>
<head><meta charset="utf-8"><title>github actions deprecation · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html">github actions deprecation</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="211944101"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/211944101" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#211944101">(Oct 01 2020 at 17:20)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="2943">@T-infra</span> just saw <a href="https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/">https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/</a>, will send a PR to rustc ASAP</p>



<a name="211944249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/211944249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#211944249">(Oct 01 2020 at 17:21)</a>:</h4>
<p>In retrospect, that's an obvious issue. Humph.</p>



<a name="211944501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/211944501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#211944501">(Oct 01 2020 at 17:23)</a>:</h4>
<p>I did not know we were using those commands, but seems good. I can review.</p>



<a name="211945042"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/211945042" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#211945042">(Oct 01 2020 at 17:27)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> that's what powers <code>ciCommandSetEnv</code> and <code>ciCommandAddPath</code></p>



<a name="211945119"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/211945119" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#211945119">(Oct 01 2020 at 17:28)</a>:</h4>
<p>thankfully we have them wrapped in custom functions, so it's like a +2/-2 PR</p>



<a name="211945404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/211945404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#211945404">(Oct 01 2020 at 17:30)</a>:</h4>
<p>ah okay</p>



<a name="212052656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212052656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212052656">(Oct 02 2020 at 09:37)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> ping about <a href="https://github.com/rust-lang/rust/pull/77418">https://github.com/rust-lang/rust/pull/77418</a></p>



<a name="212060026"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212060026" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212060026">(Oct 02 2020 at 11:03)</a>:</h4>
<p>Approved</p>



<a name="212170531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212170531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212170531">(Oct 03 2020 at 13:01)</a>:</h4>
<p>is the problem that actions can unintentionally set environment variables because their output just happened to contain <code>set-env</code>?</p>



<a name="212170574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212170574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212170574">(Oct 03 2020 at 13:02)</a>:</h4>
<p>/me is having  a hard time of thinking of anything else that "simply" moving to a file of variables would help.</p>



<a name="212170786"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212170786" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212170786">(Oct 03 2020 at 13:08)</a>:</h4>
<p>(deleted)</p>



<a name="212174273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212174273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212174273">(Oct 03 2020 at 14:13)</a>:</h4>
<p><span class="user-mention" data-user-id="123586">@nagisa</span> I think that's because it's eaiser to have something be outputted to stdout rather than being written to a file</p>



<a name="212174276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/github%20actions%20deprecation/near/212174276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/github.20actions.20deprecation.html#212174276">(Oct 03 2020 at 14:13)</a>:</h4>
<p>like, <code>curl https://example.com</code> could set an environment variable</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>